Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/23181 )
Change subject: IMPALA-14233: Fix unexpected Kudu table drop attempt on external table creation failure ...................................................................... Patch Set 1: (1 comment) Thanks for the reviews! http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23181/1//COMMIT_MSG@16 PS1, Line 16: - Existing tests cover this change. > Is it possible to add a test using the steps you mentioned in the JIRA? To I have tried to add a test and found that the situation was not as bad as I had imagined because there are additional checks in KuduCatalogOpExecutor.dropTable to ensure that the Kudu table to be dropped is a synchronized table (https://github.com/apache/impala/blob/8a691a350756d7b2f854a9da0585adb944081c6f/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java#L325). Therefore, the severity of this issue is not that high, and the related tests do not seem necessary. I have updated the commit message to include this information. -- To view, visit http://gerrit.cloudera.org:8080/23181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67d1cb333526fa41f247757997a6f7cf60d26c0b Gerrit-Change-Number: 23181 Gerrit-PatchSet: 1 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 21 Jul 2025 08:32:40 +0000 Gerrit-HasComments: Yes
