Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23152 )
Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage ...................................................................... IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage HIVE-28976 modified CommitTxnMessage to pass write ids in the message. But, catalogd do not expect write ids in the CommitTxnMessage. writeEventInfos is explicitly fetched from HMS using getAllWriteEventInfo() API and populate them to its local CommitTxnMessage object using CommitTxnMessage.addWriteEventInfo(). Since the write ids are already present in CommitTxnMessage, when we do addWriteEventInfo() on it, write ids are added again to the writeIds list in CommitTxnMessage and cause the IndexOutOfBoundsException upon CommitTxnMessage.getTableObj(i). Fix is to not populate the fetched WriteEventInfos to local CommitTxnMessage object. Instead, use them directly. Testing: - Executed existing tests. Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022 Reviewed-on: http://gerrit.cloudera.org:8080/23152 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java 1 file changed, 50 insertions(+), 39 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022 Gerrit-Change-Number: 23152 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
