Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23152 )
Change subject: IMPALA-14209: Fixed incorrect usage of WriteEventInfos with commitTxnMessage ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23152/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23152/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@960 PS1, Line 960: Map<TableName, List<Pair<Integer, Table>>> The Table is only used from the first element of the list - I think that it would be clear to use Pair<Table, List<Integer>> instead of List<Pair<Integer, Table>> -- To view, visit http://gerrit.cloudera.org:8080/23152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9b955b2b7427db9771ffec7ac5a16617f5ea022 Gerrit-Change-Number: 23152 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 14:08:56 +0000 Gerrit-HasComments: Yes
