Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/22990 )
Change subject: WIP don't review ...................................................................... Patch Set 8: (3 comments) apply this patch, performance is good. but tpcds q54/q75 crash http://gerrit.cloudera.org:8080/#/c/22990/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/22990/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@448 PS8, Line 448: if (!uniqueAnalyticExprs.contains(analyticExpr)) { tpcds query12/20: ERROR: UnsupportedOperationException: Expr.hashCode() is not implemented http://gerrit.cloudera.org:8080/#/c/22990/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java: http://gerrit.cloudera.org:8080/#/c/22990/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java@99 PS8, Line 99: outputExprs.add(CreateExprVisitor.getExpr(visitor, rexNode)); tpcds query8: ERROR: AnalysisException: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 CAUSED BY: IndexOutOfBoundsException: Index: 0, Size: 0 http://gerrit.cloudera.org:8080/#/c/22990/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java: http://gerrit.cloudera.org:8080/#/c/22990/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinProjectTransposeRule.java@104 PS8, Line 104: super.onMatch(call); tpcds q10/q35: ERROR: UncheckedExecutionException: java.lang.ArrayIndexOutOfBoundsException: 9 CAUSED BY: ArrayIndexOutOfBoundsException: 9 -- To view, visit http://gerrit.cloudera.org:8080/22990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f48c65bcf7dcfb78b9dd3ca05f505d0de979fd6 Gerrit-Change-Number: 22990 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 20 Jun 2025 07:02:18 +0000 Gerrit-HasComments: Yes
