Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/22799 )
Change subject: IMPALA-13824: Add unit tests for PlanToJson ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/22799/9/be/src/service/impala-http-handler-test.cc File be/src/service/impala-http-handler-test.cc: http://gerrit.cloudera.org:8080/#/c/22799/9/be/src/service/impala-http-handler-test.cc@347 PS9, Line 347: static void prepareCreateTableAsSelectStatement(const vector<string>& labels, > nit: please remove empty line, we usually don't put empty lines between fun Done http://gerrit.cloudera.org:8080/#/c/22799/9/be/src/service/impala-http-handler-test.cc@455 PS9, Line 455: const vector<string>& label_details, vector<TPlanFragment>* fragments, > nit: unnecessary empty line Done -- To view, visit http://gerrit.cloudera.org:8080/22799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b7f2b3a914c9091db51fbed117a80330f1d6fe5 Gerrit-Change-Number: 22799 Gerrit-PatchSet: 10 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Jun 2025 11:49:26 +0000 Gerrit-HasComments: Yes
