Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22986 )
Change subject: IMPALA-14083: Connected user and session user mismatch when cookie based authentication is used with SPNEGO ...................................................................... Patch Set 6: (4 comments) Rebased and addressed latest comments. http://gerrit.cloudera.org:8080/#/c/22986/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/22986/1/be/src/service/impala-hs2-server.cc@374 PS1, Line 374: > Thanks, while this made the patch more verbose, I think that it is clearer Agree. http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java File fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java: http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/SpnegoAuthTest.java@305 PS5, Line 305: apparentl > typo Done http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java File fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java: http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java@20 PS5, Line 20: // This code is copied from apache/thrift and modified to return > can you add the exact path? Done http://gerrit.cloudera.org:8080/#/c/22986/5/fe/src/test/java/org/apache/impala/customcluster/THttpClientWithHeaders.java@414 PS5, Line 414: } catch (IOException iox) { > This is the new code, right? Can you mark it with a comment? Done -- To view, visit http://gerrit.cloudera.org:8080/22986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7223e449c32484bfd2295f7a9e728b7c02637e9 Gerrit-Change-Number: 22986 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 12 Jun 2025 18:14:12 +0000 Gerrit-HasComments: Yes
