Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22897 )
Change subject: IMPALA-14071: Refactor MathUtil.saturatingMultiplyCardinalities() ...................................................................... Patch Set 4: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22897/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/22897/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@132 PS4, Line 132: cardinality_ = checkedAdd(cardinality_, iceFd.getFbFileMetadata().icebergMetadata().recordCount()); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/22897/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@137 PS4, Line 137: cardinality_ = checkedAdd(cardinality_, fd.getFbFileMetadata().icebergMetadata().recordCount()); line too long (104 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505ab11cfa1024feb4ceac4cffe9c3283be228ce Gerrit-Change-Number: 22897 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 May 2025 15:28:19 +0000 Gerrit-HasComments: Yes
