On 10/30/2013 1:59 AM, Ian Zimmerman wrote:
On Sun, 27 Oct 2013 23:38:43 -0400
Joe Steele <[email protected]> wrote:

Joe> I created a patch to fix this problem 4+ years ago.  It can be
Joe> found attached to this bug report:

Joe> http://savannah.nongnu.org/bugs/?26847

By the way, what do you gain by writing

rpath.conn.os.mknod(rpath.path, stat.S_IFSOCK)

instead of just

os.mknod(rpath.path, stat.S_IFSOCK)

?

To me the longer version seems to _lose_ some clarity.


Agreed -- 'os.mknod(rpath.path, stat.S_IFSOCK)' is simpler and works the same. After 4 years, I have no idea what I was thinking when I wrote it the other way. Maybe I was trying to carry on the tradition of making the inner workings of rdiff-backup difficult to comprehend? :)

--Joe

_______________________________________________
rdiff-backup-users mailing list at [email protected]
https://lists.nongnu.org/mailman/listinfo/rdiff-backup-users
Wiki URL: http://rdiff-backup.solutionsfirst.com.au/index.php/RdiffBackupWiki

Reply via email to