petr-hajek left a comment (openstreetmap/openstreetmap-website#4042)

> Whether or not the style.json path definition changes, this now looks good to 
> me. That could also be worth revisiting when there's more than one vector 
> style. Tests pass in my fork 
> [hlfan#18](https://github.com/hlfan/openstreetmap-website/pull/18). If you 
> wanna do other reviewers a favor, go through the code comments and mark 
> applicable ones as _resolved_.

I'm sorry, unfortunately I cannot resolve them, I suppose since this is not 
originally my PR, so if you can resolve those raised by you, it'd be great, 
thanks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-3031084090
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/4042/c3031084...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to