AntonKhorev left a comment (openstreetmap/openstreetmap-website#3715)
I decided to address this completely:
> Possibly it would better to add new tests rather than add lots of cases to
> the existing ones. I suspect @gravitystorm will think so though he'd probably
> also say we should split the existing one.
and split all `index` action tests, exisitng and added in this PR. Then I
discovered that I never checked if old versions of elements were redacted.
Added a fix for that too.
The expected behavior if one of the requested versions is redacted wasn't
documented anywhere, so I copied what cgimap did, which is 404 like for missing
versions and missing elements.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-3013398792
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/3715/c3013398...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
