@AntonKhorev commented on this pull request.


> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+  before_action :authorize_web
+  before_action :set_locale
+  authorize_resource :class => false
+
+  def show
+    expires_in 7.days, :public => true

I was going to say that if you want the browser to recheck whether the page has 
changed and receive `304
Not Modified` if it hasn't, this is what normally happens without extra caching 
instructions. But now I'm not entirely sure after looking at new note pages in 
the left sidebar, could be that `?xhr=1` unfinished buisiness.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106#discussion_r2150364526
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6106/review/2932712...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to