This updates the new locale menu to use a bootstrap dropdown instead of a simple HTML select so that it's appearance better matches the rest of the site.
To do this I had to move the selector out of the secondary nav bar which probably isn't ideal but without that something in bootstrap was grabbing all the list items for the dropdown and moving them to the outer list for the nav bar... That move also causes the icon to move to the right which I think is probably fine but could likely be changed if I knew what I was doing. I'm not sure the effect in small screen mode is ideal either... I did consider moving the language selector to the top to always be visible in that case which I think is fine but possibly a bit weird? Other changes are improving the tests a bit and adding an aria label to the selector button to explain what it is for screen readers (and make it easy to click in tests). New design, large screen, with menu open:  and small screen:  You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/6103 -- Commit Summary -- * Use a bootstrap dropdown for language selection -- File Changes -- M app/assets/javascripts/language_selector.js (4) M app/assets/stylesheets/common.scss (12) M app/views/layouts/_header.html.erb (16) M app/views/shared/_language_selector.html.erb (21) M config/locales/en.yml (2) M test/system/site_test.rb (28) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/6103.patch https://github.com/openstreetmap/openstreetmap-website/pull/6103.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/6103 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/6...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
