tomhughes left a comment (openstreetmap/openstreetmap-website#5906)

I honestly don't know where to start with this but it seems to me that it takes 
us from using a third party component with some reasonably simple configuration 
to writing a vast amount of code to take over much of the work which that 
component was doing.

I don't even understand how it works... Previously we had a domain of months 
broken down into days, which seems reasonable, but now we have a domain of days 
broken down into years? Except clearly we don't if look at the chart it 
produces... Is the new custom `yearly` domain badly named or something?

The question I keep asking myself every time I look at this and try and 
understand it is, is all this worth it just to make the heatmap look a bit 
closer to the github one? At least I assume that's the goal...

It would certainly be nice if we could get it to stop at the current date 
instead of the end of the current month, which seems to be the main noticeable 
effect of this to me when I try it, but is it worth this amount of work to get 
that?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5906#issuecomment-2867181800
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5906/c2867181...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to