rkoeze left a comment (openstreetmap/openstreetmap-website#5988)
As a fly-by-night contributor I'll happily defer to whatever course of action
you prefer. A couple of thoughts:
- I put together [a quick
spike](https://github.com/rkoeze/openstreetmap-website/pull/2) showing how we
might use concerns to reorganize the code in some of our larger classes. If you
think it would be worthwhile I can create an issue where we can discuss this at
more length.
- This feels like a tradeoff where neither outcome, domain logic in the
controller versus a larger User model, is perfect. I feel like the latter is a
slight improvement on the former. But then again, I authored the PR so of
course I would say that.
- Provided you agree the premise of this PR makes sense (because if it doesn't,
I can just go ahead and close it), would you like me to refrain from doing any
more work on this until the User model is cleaned up? I would prefer to push
forward but then again I just like shipping code. Don't trust me!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988#issuecomment-2861389303
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5988/c2861389...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
