@hlfan commented on this pull request.


> +<defs>
+  <path id="icon-note" fill="currentColor" d="M17 
12H15v2H13v2h2v2h2V16h2V14H17V12ZM3 12H6l2 3 2-3h3l1-1V4L13 3H3L2 4v7Z" />
+</defs>

I do think that readability wise this is difficult improve on:
https://github.com/openstreetmap/openstreetmap-website/blob/88d59de7a36b668c6f0ace10800bf4a398e3b1bc/app/views/site/welcome.html.erb#L92
https://github.com/openstreetmap/openstreetmap-website/blob/88d59de7a36b668c6f0ace10800bf4a398e3b1bc/app/views/site/fixthemap.html.erb#L23

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2022117914
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5752/review/2731064...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to