Sticky close buttons have a layer that covers their shadows when sidebars are not scrolled. That layer is slightly larger than it needs to be. It overlaps with the heading and can block out letters in the heading. I'm making the cover layer smaller in this PR.
Before:   After:   Actually with this PR the cover layer is slightly smaller than it needs to be to fully block the shadow, but hopefully it's unnoticeable. If it becomes a problem, I'll have to set sizes directly in css, currently they are set in Bootstrap units. There's also a tradeoff between not having this overlap and the heading width, given that the heading content is variable. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5790 -- Commit Summary -- * Fix overlap between left sidebar heading and close button -- File Changes -- M app/views/layouts/_sidebar_close.html.erb (2) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5790.patch https://github.com/openstreetmap/openstreetmap-website/pull/5790.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5790 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
