@AntonKhorev commented on this pull request.


> @@ -10,5 +10,11 @@
        "start_url": "/",
        "theme_color": "#7ebc6f",
        "background_color": "#fff",
-       "display": "minimal-ui"
+       "display": "minimal-ui",
+       "protocol_handlers": [
+               {
+                       "protocol": "geo",
+                       "url": "<%= Settings.server_protocol + "://" + 
Settings.server_url %>?geouri=%s"

Is `<%= Settings.server_protocol + "://" + Settings.server_url %>` required? I 
don't see url protocols/hosts in examples 
[1](https://developer.chrome.com/docs/web-platform/best-practices/url-protocol-handler)
 
[2](https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/protocol_handlers)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2652307455
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5736/review/2652307...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to