@AntonKhorev commented on this pull request.
> +<% if @heatmap_data.present? %>
+ <div class="overflow-auto" style="max-height: 500px;">
+ <%= tag.div(:id => "cal-heatmap", :data => { :heatmap =>
@heatmap_data.to_json }) %>
+ </div>
+<% end %>
You overwrite this later almost entirely. I'd keep `if` because we will not
output the heatmap [under some
conditions](https://github.com/openstreetmap/openstreetmap-website/pull/5402#issuecomment-2602166082).
`style="max-height: 500px;"` shouldn't be here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2591342660
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5402/review/2591342...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
