@AntonKhorev commented on this pull request.


> -                  <%= link_to t(".remove as friend"), 
> remove_friend_path(:display_name => @user.display_name), :method => :post %>
+                  <%= link_to t(".unfollow"), follow_path(:display_name => 
@user.display_name), :method => :delete %>
                 <% else %>
-                  <%= link_to t(".add as friend"), 
make_friend_path(:display_name => @user.display_name), :method => :post %>
+                  <%= link_to t(".follow"), follow_path(:display_name => 
@user.display_name), :method => :post %>

This doesn't quite work. There's a link that points to `/user/.../follow`. I 
can try to open it in a new tab and it won't work because the page doesn't 
exist. The page is at `.../edit` but you can't change the link to `.../edit` 
because you can't post/delete it. Looks like that out of options in 
https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1874500481
 `:show` would have worked the best, especially if you agree with 
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2578415862.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#pullrequestreview-2542473003
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5261/review/2542473...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to