@gravitystorm requested changes on this pull request.
Great! Well done on getting this working. I've added a couple of points inline,
but otherwise I'm happy to merge.
> @@ -144,6 +144,9 @@ gem "unicode-display_width"
# Keep ruby 3.0 compatibility
gem "multi_xml", "~> 0.6.0"
+gem "teaspoon"
+gem "teaspoon-mocha", "~> 2.3.3"
These gems shouldn't be in the production section, either `group :test` or
`group :development, :test`
Since teaspoon-mocha depends on teaspoon, there's no need to add it separately
> @@ -9,6 +9,13 @@ SET xmloption = content;
SET client_min_messages = warning;
SET row_security = off;
+--
+-- Name: public; Type: SCHEMA; Schema: -; Owner: -
+--
+
+-- *not* creating schema, since initdb creates it
+
+
There shouldn't be any changes to db/structure.sql in this PR
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5216#pullrequestreview-2343553390
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5216/review/2343553...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
