> The timezone database lookup logic is in the `tzinfo` package > (https://docs.racket-lang.org/tzinfo/index.html)
Thanks. > Jon: I'm guessing you haven't actually tried this > Phillip: I guess the check doesn't happen as part of `tz/c`, but I can tell > you that this program Yes, but I'm talking about code we were asked to give feedback on. I focus on `tz/c` because it is documented as a flat contract that checks for "an identifier from the IANA [tz database](https://www.iana.org/time-zones)", but it does not parse the timezone name to check correctness. My feedback says no validation occurs for the timezone name in a parameter for Splitflap. Joel indicated that parameter will go away below, and I'm glad to know of the tzinfo package. But if a limitation in gregor's contracts would oblige you to use tzinfo for validation, then I'd want to know that so that I can assess how much of gregor I really need. It still seems like the timezone data is the hard part, so use a timezone dependency instead of a dependency that misleads the user into incomplete validation. On 10/26/21 12:39 PM, 'Joel Dueck' via Racket Users wrote: > On Tuesday, October 26, 2021 at 11:01:38 AM UTC-5 Sage Gerard wrote: > >> - Assuming I have the right repository link, gregor's tz/c contract is only >> (or/c string? (integer-in -64800 64800)) [1]. I can set the feed-timezone >> parameter in Splitflap to an arbitrary string and the guard won't stop me. > > Yep — I left feed-timezone out of the docs because I plan to remove it. > Unless I'm missing something? in the end I think it's redundant to tzinfo's > current-timezone parameter. > -- > You received this message because you are subscribed to the Google Groups > "Racket Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > [https://groups.google.com/d/msgid/racket-users/d202c537-0173-42fd-b75f-082275c57426n%40googlegroups.com](https://groups.google.com/d/msgid/racket-users/d202c537-0173-42fd-b75f-082275c57426n%40googlegroups.com?utm_medium=email&utm_source=footer). -- You received this message because you are subscribed to the Google Groups "Racket Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/racket-users/f879496a-04c6-e5dd-2501-928a4eff7fb2%40sagegerard.com.
