Hi, On Mon, Jan 19, 2015 at 03:06:11PM -0500, Duncan Murdoch wrote: > On 19/01/2015 2:33 PM, Felipe Balbi wrote: > > git has an interface for cloning SVN repositories into git which > > some users might decide to use. For those users' surprise, the > > repository will always fail to build on svnonly target and it will > > exit early. > > > > The problem is simple enough to fix by just checking if a .git > > directory exists in top_builddir and, if so, call git svn info insstead > > of svn info. > > > > I think we are unlikely to accept this change. Nobody in R Core uses > git this way, so it would never be tested, and would likely soon fail.
it will be tested by anybody using git svn clone, right ? > Indeed, it already fails if someone were to try it on Windows, since you > didn't patch the makefiles for that platform. yeah, sorry about that, I wasn't aware there were windows-specific Makefiles with duplicated logic in the repository. > The R sources are kept in an SVN repository, and as long as that's true, > we're only likely to support direct SVN access. Fair enough. But don't you think it's a bit odd to couple the repository compilation with the availability of a specific SCM tool ? I mean, R just won't build unless you have svn info available, I think that's pretty odd. Printing a warning would be another possibility, but exitting build is almost an overreaction. But fair enough, no need to spend days discussing $subject if the community doesn't want to support git svn clone ;-) cheers -- balbi
signature.asc
Description: Digital signature
______________________________________________ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel
