Hi Philippe, On Fri, Oct 13, 2023 at 04:01:01PM +0200, Philippe Mathieu-Daudé wrote: > Date: Fri, 13 Oct 2023 16:01:01 +0200 > From: Philippe Mathieu-Daudé <[email protected]> > Subject: [PATCH v2 02/16] target: Mention 'cpu-qom.h' is target agnostic > X-Mailer: git-send-email 2.41.0 > > "target/foo/cpu-qom.h" is supposed to be target agnostic > (include-able by any target). Add such mention in the > header. > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > Reviewed-by: Richard Henderson <[email protected]> > --- > target/arm/cpu-qom.h | 2 +- > target/hppa/cpu-qom.h | 2 +- > target/microblaze/cpu-qom.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-)
Why not mention this description for other qom-cpu.h in this series, e.g., target/i386/cpu-qom.h. Otherwise, Reviewed-by: Zhao Liu <[email protected]> > > diff --git a/target/arm/cpu-qom.h b/target/arm/cpu-qom.h > index 153865d1bb..dfb9d5b827 100644 > --- a/target/arm/cpu-qom.h > +++ b/target/arm/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU ARM CPU > + * QEMU ARM CPU QOM header (target agnostic) > * > * Copyright (c) 2012 SUSE LINUX Products GmbH > * > diff --git a/target/hppa/cpu-qom.h b/target/hppa/cpu-qom.h > index 67f12422c4..4b1d48f7ca 100644 > --- a/target/hppa/cpu-qom.h > +++ b/target/hppa/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU HPPA CPU > + * QEMU HPPA CPU QOM header (target agnostic) > * > * Copyright (c) 2016 Richard Henderson <[email protected]> > * > diff --git a/target/microblaze/cpu-qom.h b/target/microblaze/cpu-qom.h > index 2a734e644d..78f549b57d 100644 > --- a/target/microblaze/cpu-qom.h > +++ b/target/microblaze/cpu-qom.h > @@ -1,5 +1,5 @@ > /* > - * QEMU MicroBlaze CPU > + * QEMU MicroBlaze CPU QOM header (target agnostic) > * > * Copyright (c) 2012 SUSE LINUX Products GmbH > * > -- > 2.41.0 > > >
