On Tue, 17 Oct 2023 at 13:48, Philippe Mathieu-Daudé <[email protected]> wrote: > > On 17/10/23 14:23, Peter Maydell wrote: > > Convert the hw/input/stellaris_input device to qdev. > > > > The interface uses an array property for the board to specify the > > keycodes to use, so the s->keycodes memory is now allocated by the > > array-property machinery. > > > > Signed-off-by: Peter Maydell <[email protected]> > > --- > > include/hw/input/stellaris_gamepad.h | 25 +++++++++- > > hw/arm/stellaris.c | 26 +++++++--- > > hw/input/stellaris_gamepad.c | 73 +++++++++++++++++++--------- > > 3 files changed, 92 insertions(+), 32 deletions(-) > > > > +#define TYPE_STELLARIS_GAMEPAD "stellaris-gamepad" > > +OBJECT_DECLARE_SIMPLE_TYPE(StellarisGamepad, STELLARIS_GAMEPAD) > > + > > +struct StellarisGamepad { > > + /*< private >*/ > > Since commit 067109a11c ("docs/devel: mention the spacing requirement > for QOM") we don't use these private/public comments anymore.
Oh, good. I never really understood the purpose of them. We still have a lot of them in the codebase, though... thanks -- PMM
