> From: David Hildenbrand <[email protected]> > Sent: Monday, October 9, 2023 1:23 PM > To: Salil Mehta <[email protected]>; [email protected]; qemu- > [email protected] > Cc: [email protected]; [email protected]; Jonathan Cameron > <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; zhukeqian > <[email protected]>; wangxiongfeng (C) <[email protected]>; > wangyanan (Y) <[email protected]>; [email protected]; > [email protected]; [email protected]; Linuxarm <[email protected]> > Subject: Re: [PATCH V3 03/10] hw/acpi: Add ACPI CPU hotplug init stub > > On 09.10.23 13:28, Salil Mehta wrote: > > ACPI CPU hotplug related initialization should only happen if > ACPI_CPU_HOTPLUG > > support has been enabled for particular architecture. Add > cpu_hotplug_hw_init() > > stub to avoid compilation break. > > > > Signed-off-by: Salil Mehta <[email protected]> > > Reviewed-by: Jonathan Cameron <[email protected]> > > Reviewed-by: Gavin Shan <[email protected]> > > --- > > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug- > stub.c > > index 3fc4b14c26..c6c61bb9cd 100644 > > --- a/hw/acpi/acpi-cpu-hotplug-stub.c > > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c > > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion > *parent, Object *owner, > > return; > > } > > > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > > + CPUHotplugState *state, hwaddr base_addr) > > +{ > > + return; > > +} > > While at it, can we prefix that function with acpi?
I can do that but it has to be done at other places as well such as in hw/acpi/cpu_hotplug.c <acpi_switch_to_modern_cphp()> Hope this is not an extraneous change to this patch-set? Thanks Salil.
