Markus Armbruster <[email protected]> wrote:
> Functions that use an Error **errp parameter to return errors should
> not also report them to the user, because reporting is the caller's
> job.  When the caller does, the error is reported twice.  When it
> doesn't (because it recovered from the error), there is no error to
> report, i.e. the report is bogus.
>
> Macro ERROR() violates this principle.  Delete the error_report()
> there.
>
> Signed-off-by: Markus Armbruster <[email protected]>
> Reviewed-by: Li Zhijian <[email protected]>
> Tested-by: Li Zhijian <[email protected]>

Reviewed-by: Juan Quintela <[email protected]>


Reply via email to