Markus Armbruster <[email protected]> wrote: > rdma_getaddrinfo() returns 0 on success. On error, it returns one of > the EAI_ error codes like getaddrinfo() does, or -1 with errno set. > This is broken by design: POSIX implicitly specifies the EAI_ error > codes to be non-zero, no more. They could clash with -1. Nothing we > can do about this design flaw. > > Both callers of rdma_getaddrinfo() only recognize negative values as > error. Works only because systems elect to make the EAI_ error codes > negative. > > Best not to rely on that: change the callers to treat any non-zero > value as failure. Also change them to return -1 instead of the value > received from getaddrinfo() on failure, to avoid positive error > values. > > Signed-off-by: Markus Armbruster <[email protected]> > Reviewed-by: Li Zhijian <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
