On 10/9/23 22:59, Roman Bolshakov wrote:
On Tue, Sep 05, 2023 at 02:39:06PM +0200, Philippe Mathieu-Daudé wrote:
hvf_get_supported_cpuid() is only defined for x86 targets
(in target/i386/hvf/x86_cpuid.c).
Its declaration is pointless on all other targets.

All the calls to it in target/i386/cpu.c are guarded by
a call on hvf_enabled(), so are elided when HVF is not
built in. Therefore we can remove the unnecessary function
stub.


Looks good but you also need to include "hvf/hvf-i386.h" to
target/i386/hvf/hvf-cpu.c, otherwise the build fails.

Oops, thanks for testing!


Reply via email to