> From: Jonathan Cameron <[email protected]> > Sent: Tuesday, October 3, 2023 12:54 PM > To: Salil Mehta <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; jean- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; zhukeqian > <[email protected]>; wangxiongfeng (C) <[email protected]>; > wangyanan (Y) <[email protected]>; [email protected]; > [email protected]; [email protected]; Linuxarm <[email protected]> > Subject: Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu > scan > > > > > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE), > > > > diff --git a/include/hw/acpi/cpu_hotplug.h > > > b/include/hw/acpi/cpu_hotplug.h > > > > index 48b291e45e..ef631750b4 100644 > > > > --- a/include/hw/acpi/cpu_hotplug.h > > > > +++ b/include/hw/acpi/cpu_hotplug.h > > > > @@ -20,6 +20,8 @@ > > > > #include "hw/acpi/cpu.h" > > > > > > > > #define ACPI_CPU_HOTPLUG_REG_LEN 12 > > > > +#define ACPI_CPU_SCAN_METHOD "CSCN" > > > > > > This seems to already be defined in hw/acpi/cpu.c > > > Can we drop it from there given that file now includes this > > > header anyway. > > > > Perhaps I can assign this to the macro in the hw/acpi/cpu.c? > hw/acpi/cpu.c includes this header now anyway I think. > So just drop that definition and should all be good.
Ok.
