> From: Gavin Shan <[email protected]>
> Sent: Tuesday, October 3, 2023 12:25 AM
> To: Salil Mehta <[email protected]>; [email protected]; qemu-
> [email protected]
> Cc: [email protected]; [email protected]; Jonathan Cameron
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; zhukeqian
> <[email protected]>; wangxiongfeng (C) <[email protected]>;
> wangyanan (Y) <[email protected]>; [email protected];
> [email protected]; [email protected]; Linuxarm <[email protected]>
> Subject: Re: [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub
>
>
> On 9/30/23 10:19, Salil Mehta wrote:
> > ACPI CPU hotplug related initialization should only happen if
> ACPI_CPU_HOTPLUG
> > support has been enabled for particular architecture. Add
> cpu_hotplug_hw_init()
> > stub to avoid compilation break.
> >
> > Signed-off-by: Salil Mehta <[email protected]>
> > ---
> > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
>
> Reviewed-by: Gavin Shan <[email protected]>
Thanks
Salil.
>
> > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-
> stub.c
> > index 3fc4b14c26..c6c61bb9cd 100644
> > --- a/hw/acpi/acpi-cpu-hotplug-stub.c
> > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c
> > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion
> *parent, Object *owner,
> > return;
> > }
> >
> > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
> > + CPUHotplugState *state, hwaddr base_addr)
> > +{
> > + return;
> ^^^^^^
> > +}
> > +
>
> I guess the return is the outcome by following the pattern of other
> functions ;-)
I can remove it. :)
