On 7/10/23 15:44, Joao Martins wrote:


On 09/07/2023 16:17, Avihai Horon wrote:

On 23/06/2023 0:48, Joao Martins wrote:
External email: Use caution opening links or attachments


From: Avihai Horon <[email protected]>

Implement get_attr() method and use the address width property to report
the IOMMU_ATTR_MAX_IOVA attribute.

Nit: get_attr() method was already implemented in patch #6.
Maybe just "Use address width property to report IOMMU_ATTR_MAX_IOVA attribute"?

Yeap, makes sense.

I would merge with the previous patch also.


Thanks.


Signed-off-by: Avihai Horon <[email protected]>
Signed-off-by: Joao Martins <[email protected]>
---
   hw/i386/intel_iommu.c | 7 +++++++
   1 file changed, 7 insertions(+)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index ed2a46e008df..989993e303a6 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3876,6 +3876,13 @@ static int vtd_iommu_get_attr(IOMMUMemoryRegion 
*iommu_mr,
           *enabled = s->dma_translation;
           break;
       }
+    case IOMMU_ATTR_MAX_IOVA:
+    {
+        hwaddr *max_iova = (hwaddr *)(uintptr_t) data;
+
+        *max_iova = MAKE_64BIT_MASK(0, s->aw_bits);;

one ; is enough.

Thanks,

C.

+        break;
+    }
       default:
           ret = -EINVAL;
           break;
--
2.17.2




Reply via email to