Hi Phillipe, This patch has been taken as it is from ARM's RFC and the common patch-set mentioned below. So SOBs are all wrong everywhere.
Original RFC posted in the year 2020. [1] https://lore.kernel.org/qemu-devel/[email protected]/ Recently posted RFC V2 [2] https://lore.kernel.org/qemu-devel/[email protected]/T/#m5f5ae40b091d69d01012880d7500d96874a9d39c Recent common patch-set for Virtual CPU Hotplug [3] https://lore.kernel.org/qemu-devel/[email protected]/ [4] https://lore.kernel.org/qemu-devel/[email protected]/ Beside my original patch-set had bug which you have inherited in this patch-set. Thanks Salil > From: [email protected] <qemu-arm- > [email protected]> On Behalf Of Philippe Mathieu- > Daudé > Sent: Monday, September 18, 2023 5:03 PM > To: [email protected] > Cc: Laurent Vivier <[email protected]>; Paolo Bonzini > <[email protected]>; Max Filippov <[email protected]>; David Hildenbrand > <[email protected]>; Peter Xu <[email protected]>; Anton Johansson > <[email protected]>; Peter Maydell <[email protected]>; > [email protected]; Marek Vasut <[email protected]>; David Gibson > <[email protected]>; Brian Cain <[email protected]>; Yoshinori > Sato <[email protected]>; Edgar E . Iglesias > <[email protected]>; Claudio Fontana <[email protected]>; Daniel > Henrique Barboza <[email protected]>; Artyom Tarasenko > <[email protected]>; Marcelo Tosatti <[email protected]>; qemu- > [email protected]; Liu Zhiwei <[email protected]>; Aurelien Jarno > <[email protected]>; Ilya Leoshkevich <[email protected]>; Daniel > Henrique Barboza <[email protected]>; Bastian Koppelmann > <[email protected]>; Cédric Le Goater <[email protected]>; Alistair > Francis <[email protected]>; Alessandro Di Federico <[email protected]>; > Song Gao <[email protected]>; Marcel Apfelbaum > <[email protected]>; Chris Wulff <[email protected]>; Michael S. > Tsirkin <[email protected]>; Alistair Francis <[email protected]>; > Fabiano Rosas <[email protected]>; [email protected]; wangyanan (Y) > <[email protected]>; Luc Michel <[email protected]>; Weiwei Li > <[email protected]>; Bin Meng <[email protected]>; Stafford Horne > <[email protected]>; Xiaojuan Yang <[email protected]>; Daniel P . > Berrange <[email protected]>; Thomas Huth <[email protected]>; Philippe > Mathieu-Daudé <[email protected]>; [email protected]; Jiaxun Yang > <[email protected]>; Richard Henderson > <[email protected]>; Aleksandar Rikalo > <[email protected]>; Bernhard Beschow <[email protected]>; Mark > Cave-Ayland <[email protected]>; [email protected]; Alex > Bennée <[email protected]>; Nicholas Piggin <[email protected]>; Greg > Kurz <[email protected]>; Michael Rolnik <[email protected]>; Eduardo Habkost > <[email protected]>; Markus Armbruster <[email protected]>; Palmer > Dabbelt <[email protected]>; xianglai li <[email protected]>; Salil > Mehta <[email protected]>; Igor Mammedov <[email protected]>; Ani > Sinha <[email protected]>; Bibo Mao <[email protected]> > Subject: [PATCH 07/22] exec/cpu: Introduce the CPU address space > destruction function > > From: xianglai li <[email protected]> > > Introduce new function to destroy CPU address space resources > for cpu hot-(un)plug. > > Co-authored-by: "Salil Mehta" <[email protected]> > Cc: "Salil Mehta" <[email protected]> > Cc: Xiaojuan Yang <[email protected]> > Cc: Song Gao <[email protected]> > Cc: "Michael S. Tsirkin" <[email protected]> > Cc: Igor Mammedov <[email protected]> > Cc: Ani Sinha <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: Richard Henderson <[email protected]> > Cc: Eduardo Habkost <[email protected]> > Cc: Marcel Apfelbaum <[email protected]> > Cc: "Philippe Mathieu-Daudé" <[email protected]> > Cc: Yanan Wang <[email protected]> > Cc: "Daniel P. Berrangé" <[email protected]> > Cc: Peter Xu <[email protected]> > Cc: David Hildenbrand <[email protected]> > Cc: Bibo Mao <[email protected]> > Signed-off-by: xianglai li <[email protected]> > Message-ID: > <3a4fc2a3df4b767c3c296a7da3bc15ca9c251316.1694433326.git.lixianglai@loongso > n.cn> > --- > include/exec/cpu-common.h | 8 ++++++++ > include/hw/core/cpu.h | 1 + > softmmu/physmem.c | 24 ++++++++++++++++++++++++ > 3 files changed, 33 insertions(+) > > diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h > index 41788c0bdd..eb56a228a2 100644 > --- a/include/exec/cpu-common.h > +++ b/include/exec/cpu-common.h > @@ -120,6 +120,14 @@ size_t qemu_ram_pagesize_largest(void); > */ > void cpu_address_space_init(CPUState *cpu, int asidx, > const char *prefix, MemoryRegion *mr); > +/** > + * cpu_address_space_destroy: > + * @cpu: CPU for which address space needs to be destroyed > + * @asidx: integer index of this address space > + * > + * Note that with KVM only one address space is supported. > + */ > +void cpu_address_space_destroy(CPUState *cpu, int asidx); > > void cpu_physical_memory_rw(hwaddr addr, void *buf, > hwaddr len, bool is_write); > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > index 92a4234439..c90cf3a162 100644 > --- a/include/hw/core/cpu.h > +++ b/include/hw/core/cpu.h > @@ -366,6 +366,7 @@ struct CPUState { > QSIMPLEQ_HEAD(, qemu_work_item) work_list; > > CPUAddressSpace *cpu_ases; > + int cpu_ases_ref_count; > int num_ases; > AddressSpace *as; > MemoryRegion *memory; > diff --git a/softmmu/physmem.c b/softmmu/physmem.c > index 18277ddd67..c75e3e8042 100644 > --- a/softmmu/physmem.c > +++ b/softmmu/physmem.c > @@ -761,6 +761,7 @@ void cpu_address_space_init(CPUState *cpu, int asidx, > > if (!cpu->cpu_ases) { > cpu->cpu_ases = g_new0(CPUAddressSpace, cpu->num_ases); > + cpu->cpu_ases_ref_count = cpu->num_ases; > } > > newas = &cpu->cpu_ases[asidx]; > @@ -774,6 +775,29 @@ void cpu_address_space_init(CPUState *cpu, int asidx, > } > } > > +void cpu_address_space_destroy(CPUState *cpu, int asidx) > +{ > + CPUAddressSpace *cpuas; > + > + assert(asidx < cpu->num_ases); > + assert(asidx == 0 || !kvm_enabled()); > + assert(cpu->cpu_ases); > + > + cpuas = &cpu->cpu_ases[asidx]; > + if (tcg_enabled()) { > + memory_listener_unregister(&cpuas->tcg_as_listener); > + } > + > + address_space_destroy(cpuas->as); > + > + cpu->cpu_ases_ref_count--; > + if (cpu->cpu_ases_ref_count == 0) { > + g_free(cpu->cpu_ases); > + cpu->cpu_ases = NULL; > + } > + > +} > + > AddressSpace *cpu_get_address_space(CPUState *cpu, int asidx) > { > /* Return the AddressSpace corresponding to the specified index */ > -- > 2.41.0 > >
