On Mon, Oct 2, 2023 at 11:58 AM Marc-André Lureau <[email protected]> wrote: > > Hi > > On Mon, Oct 2, 2023 at 1:54 PM Paolo Bonzini <[email protected]> wrote: > > > > VGA does not support getting the physical video size or refresh rate. > > This is causing an assertion failure when the GTK+ user interface > > calls dpy_get_ui_info(). Return NULL from dpy_get_ui_info() if the > > information is not supported, and just ignore the request to set > > refresh rate or size in that case. > > > > While the assertion failure was introduced by commit a92e7bb4cad > > ("ui: add precondition for dpy_get_ui_info()", 2023-09-12), QEMU had > > been using con->ui_info incorrectly since before. > > > > Fixes: a92e7bb4cad ("ui: add precondition for dpy_get_ui_info()", > > 2023-09-12) > > Fixes: aeffd071ed8 ("ui: Deliver refresh rate via QemuUIInfo", 2022-06-14) > > Signed-off-by: Paolo Bonzini <[email protected]> > > Did you see my patch ? > https://lore.kernel.org/qemu-devel/[email protected]/ > > I think I prefer mine :)
I hadn't seen it, either is okay with me. Paolo
