Ani Sinha <[email protected]> writes: >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster <[email protected]> wrote: >> >> From: Ani Sinha <[email protected]> >> >> Code changes in acpi that addresses all compiler complaints coming from >> enabling >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >> other local variables or parameters. These makes the code confusing and/or >> adds >> bugs that are difficult to catch. See also >> >> Subject: Help wanted for enabling -Wshadow=local >> Message-Id: <[email protected]> >> https://lore.kernel.org/qemu-devel/[email protected] >> >> The code is tested to build with and without the flag turned on. >> >> CC: Markus Armbruster <[email protected]> >> CC: Philippe Mathieu-Daude <[email protected]> >> CC: [email protected] >> CC: [email protected] >> Signed-off-by: Ani Sinha <[email protected]> >> Message-ID: <[email protected]> >> Reviewed-by: Michael S. Tsirkin <[email protected]> >> [Commit message tweaked] >> Signed-off-by: Markus Armbruster <[email protected]> > > Thanks! > Are you not going to pick up "hw/i386: changes towards enabling > -Wshadow=local” ?
Your conversation with Michael looked unfinished to me, so I didn't include your patch in my pull request. I did add it to shadow-next.
