Thomas Huth <[email protected]> writes: > On 25/09/2023 16.47, Paolo Bonzini wrote: >> Rename the variable "s" and, while at it, avoid the chance of an overflow in >> the >> computation of ABS(t - s). >> Signed-off-by: Paolo Bonzini <[email protected]> >> --- >> tests/qtest/m48t59-test.c | 17 ++++++++++------- >> 1 file changed, 10 insertions(+), 7 deletions(-) > > I've got a patch for this in my pull request from today already: > > https://lore.kernel.org/qemu-devel/[email protected]
Commit 926bef1d82bb9eb7a752aa128d9e70b808906243. Paolo's patch still applies, and "avoid the chance of an overflow in the computation of ABS(t - s)" makes me think we still want it. The commit message needs a tweak, though, since the patch no longer removes shadowed variables.
