On Wed, Sep 20, 2023 at 09:53:46AM -0300, Jason Gunthorpe wrote: > On Wed, Sep 20, 2023 at 01:39:02PM +0100, Daniel P. Berrangé wrote: > > > > diff --git a/util/chardev_open.c b/util/chardev_open.c > > > new file mode 100644 > > > index 0000000000..d03e415131 > > > --- /dev/null > > > +++ b/util/chardev_open.c > > > @@ -0,0 +1,61 @@ > > > +/* > > > + * Copyright (C) 2023 Intel Corporation. > > > + * Copyright (c) 2019, Mellanox Technologies. All rights reserved. > > > + * > > > + * Authors: Yi Liu <[email protected]> > > > + * > > > + * This work is licensed under the terms of the GNU GPL, version 2. See > > > + * the COPYING file in the top-level directory. > > > + * > > > + * Copied from > > > + * https://github.com/linux-rdma/rdma-core/blob/master/util/open_cdev.c > > > + * > > > + */ > > > > Since this is GPL-2.0-only, IMHO it would be preferrable to keep it > > out of the util/ directory, as we're aiming to not add further 2.0 > > only code, except for specific subdirs. This only appears to be used > > by code under hw/vfio/, whcih is one of the dirs still permitting > > 2.0-only code. So I think better to keep this file where it is used. > > The copyright comment above is not fully accurate. > > The original code is under the "OpenIB" dual license, you can choose > to take it using the OpenIB BSD license text: > > * Redistribution and use in source and binary forms, with or > * without modification, are permitted provided that the following > * conditions are met: > * > * - Redistributions of source code must retain the above > * copyright notice, this list of conditions and the following > * disclaimer. > * > * - Redistributions in binary form must reproduce the above > * copyright notice, this list of conditions and the following > * disclaimer in the documentation and/or other materials > * provided with the distribution. > * > * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > * SOFTWARE. > > And drop reference to GPL if that is what qemu desires.
Simplest is probably just to copy the original license header as-is, and thus preserve the GPL OR BSD choice. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
