----- Original Message ----- > From: "Stefan Hajnoczi" <[email protected]> > To: "Federico Simoncelli" <[email protected]> > Cc: [email protected], [email protected], [email protected] > Sent: Thursday, February 23, 2012 5:14:09 PM > Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver > > On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli > <[email protected]> wrote: > > From: Marcelo Tosatti <[email protected]> > > > > Mirrored writes are used by live block copy. > > I think the right approach is to create a single blkmirror driver > that > also includes blkverify functionality. The code is basically the > same > except blkverify also compares reads - just use a flag to > enable/disable that behavior. > > Feel free to rename the blkverify driver to blkmirror if you wish. > > By the way, this code does not build against qemu.git/master. It > uses > interfaces which have been dropped.
Yes you also need: [PATCH 2/3] Update the blkmirror block driver Which was sent separately to facilitate the review for people who already reviewed this. -- Federico
