On Mon, Sep 04, 2023 at 06:02:14PM +0100, Jonathan Cameron wrote: > On Thu, 31 Aug 2023 21:29:13 -0400 > Gregory Price <[email protected]> wrote: > > > When memory accesses are made, some MHSLD's would validate the address > > is within the scope of allocated sections. To do this, the base device > > must call an optional function set by inherited devices. > > > > Signed-off-by: Gregory Price <[email protected]> > > This sort of callback addition can be done via class initialization. > E.g. get_lsa_size() > https://elixir.bootlin.com/qemu/latest/source/hw/mem/cxl_type3.c#L1494 > as the callback is the same for all instances of the class which > in next patch is CXLNiagraClass where you already set the > PCIClass callbacks in cxl_niagara_class_init() > > You can then use something like: > CXLType3Class *cvc = CXL_TYPE3_GET_CLASS(ct3d); > cvc->mhd_access_valid(ct3d, dpa_offset, size); > > Jonathan >
Will make this change along with a few cleanups suggested elsewhere and a few boneheaded mistakes. ~Gregory
