On 23 February 2012 09:48, Markus Armbruster <[email protected]> wrote:
> andrzej zaborowski <[email protected]> writes:
>
>> On 23 February 2012 09:20, Gerd Hoffmann <[email protected]> wrote:
>>> $subject says all, which pretty much breaks libvirt-managed qemu ...
>>
>> Also "device_add nonexistent-device" in the monitor gives a rather
>> unhelpful message:
>>
>> Parameter 'driver' expects device type
>
> "-device foo" is really shorthand for "-device driver=foo".  And deep
> down in the bowels of qdev, where the error get reported, the value of
> parameter "driver" gets treated like any other parameter's value: if
> it's not within ACCEPTABLE-SET, complain "Parameter 'NAME' expected
> ACCEPTABLE-SET".

Yeah, I looked at this code, perhaps "'INPUT' is not a valid
'ACCEPTABLE-SET'" would be more helpful.  In my message I was talking
about the monitor command though.  Something like "you typoed in the
device name" should be reported by the human readable monitor.

Cheers

Reply via email to