On Sun, Aug 27, 2023 at 08:29:36PM +0200, Laszlo Ersek wrote:
The "vhost_set_vring" function already centralizes the common parts of
"vhost_user_set_vring_num", "vhost_user_set_vring_base" and
"vhost_user_set_vring_enable". We'll want to allow some of those callers
to wait for a reply.
Therefore, rebase "vhost_set_vring" from just "vhost_user_write" to
"vhost_user_write_msg", exposing the "wait_for_reply" parameter.
This is purely refactoring -- there is no observable change. That's
because:
- all three callers pass in "false" for "wait_for_reply", which disables
all logic in "vhost_user_write_msg" except the call to
"vhost_user_write";
- the fds=NULL and fd_num=0 arguments of the original "vhost_user_write"
call inside "vhost_set_vring" are hard-coded within
"vhost_user_write_msg".
Cc: "Michael S. Tsirkin" <[email protected]> (supporter:vhost)
Cc: Eugenio Perez Martin <[email protected]>
Cc: German Maglione <[email protected]>
Cc: Liu Jiang <[email protected]>
Cc: Sergio Lopez Pascual <[email protected]>
Cc: Stefano Garzarella <[email protected]>
Signed-off-by: Laszlo Ersek <[email protected]>
---
hw/virtio/vhost-user.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Stefano Garzarella <[email protected]>
