On Wed, 2023-08-23 at 22:00 +0300, Michael Tokarev wrote: > 23.08.2023 21:38, David Woodhouse wrote: > > On Wed, 2023-08-23 at 09:53 +0300, Michael Tokarev wrote: > > > > > > include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +- > > > include/hw/xen/interface/arch-x86/xen.h | 2 +- > > > include/hw/xen/interface/event_channel.h | 2 +- > > > include/hw/xen/interface/grant_table.h | 2 +- > > > include/hw/xen/interface/hvm/hvm_op.h | 2 +- > > > include/hw/xen/interface/io/blkif.h | 6 +++--- > > > include/hw/xen/interface/io/fbif.h | 2 +- > > > include/hw/xen/interface/io/kbdif.h | 2 +- > > > include/hw/xen/interface/memory.h | 2 +- > > > include/hw/xen/interface/physdev.h | 4 ++-- > > > include/hw/xen/interface/xen.h | 4 ++-- > > > 12 files changed, 16 insertions(+), 16 deletions(-) > > > > Please don't make changes to these unless you also change them in the > > upstream Xen project, from which they're imported. > > Aha. I didn't know they're imported from elsewhere. > Is it just include/hw/xen/interface/ or whole include/hw/xen/ ?
For this particular set of imported files, I believe it's just the ones in include/hw/xen/interface/ > I guess these changes can be sent to xen project :) Maybe we should add it in MAINTAINERS? :) > > > - * any large discontiguities in the machine address space, 2MB gaps > > > in > > > + * any large discontinuities in the machine address space, 2MB gaps > > > in > > > > If you're already correcting that line, why not also correct MB to MiB? > > That's not really spelling fix anymore. Also, this is not universal, some > still prefer MB over MiB (to mean 1024 not 1000). Else it's just too many > changes and the thing will never finish :) I'll buy your second reason, but not the first. I don't think there's a good reason to be tolerant of people who "prefer" to be deliberately wrong. MB means one thing, MiB — the IEC standard since 1998 — means something else. To use one when you mean the other is just wrong. Maybe in the final years of the 1900s when the IEC standard was still new, and people found MiB unfamiliar and "ugly", it wasn't universal. That was quarter of a century ago. The unfamiliarity, and thus the natural human reaction to perceive anything new as "ugly", will pass. The correctness, and the lack of ambiguity, will not. > Here in this patch, after removing include/hw/xen/, there's just one file > with one fix left, hw/xen/xen_pvdev.c. Hwell.. :) For that part, Acked-by: David Woodhouse <d...@amazon.co.uk>
smime.p7s
Description: S/MIME cryptographic signature
