On Wed, Aug 23, 2023 at 08:51:53AM +0300, Michael Tokarev wrote: > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > ---
> +++ b/tests/qemu-iotests/298 > @@ -142,5 +142,5 @@ class TestTruncate(iotests.QMPTestCase): > > # Probably we'll want preallocate filter to keep align to cluster > when > - # shrink preallocation, so, ignore small differece > + # shrink preallocation, so, ignore small difference The sentence as a whole still comes across awkwardly; maybe shorten and reword to: The preallocate filter may keep cluster alignment when shrinking, so ignore small differences > +++ b/tests/qtest/fuzz/generic_fuzz.c > @@ -847,7 +847,7 @@ static void generic_pre_fuzz(QTestState *s) > * > * This function attempts to produce an input that: > - * Ouptut: maps a device's BARs, set up three DMA patterns, triggers > + * Output: maps a device's BARs, set up three DMA patterns, triggers > * functionality A device, replaces the DMA patterns with a single > - * patten, and triggers device functionality B. > + * pattern, and triggers device functionality B. As long as you're touching neighboring lines, s/functionality A device/device functionality A/ > +++ b/tests/unit/test-throttle.c > @@ -136,5 +136,5 @@ static void test_compute_wait(void) > g_assert(double_cmp(bkt.level, (i + 1) * (bkt.max - bkt.avg) / 10)); > /* We can do bursts for the 2 seconds we have configured in > - * burst_length. We have 100 extra miliseconds of burst > + * burst_length. We have 100 extra milliseconds of burst > * because bkt.level has been leaking during this time. > * After that, we have to wait. */ > @@ -380,5 +380,5 @@ static void test_is_valid(void) > /* zero are valids */ > test_is_valid_for_value(0, true); > - /* positives numers are valids */ > + /* positives numbers are valids */ Multiple grammar errors in this function. Should be: /* negative numbers are invalid */ /* zero is valid */ /* positive numbers are valid */ All other changes in this patch look good. With additional tweaks, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
