On Wed, Aug 16, 2023 at 11:25:10AM -0300, Fabiano Rosas wrote: > @@ -2003,6 +1980,8 @@ static int open_return_path_on_source(MigrationState > *ms) > return -1; > } > > + > migration_ioc_register_yank(qemu_file_get_ioc(ms->rp_state.from_dst_file));
I think I didn't really get why it wasn't paired before yesterday. My fault. Registering from_dst_file, afaict, will register two identical yank objects because the ioc is the same. Should we make migration_file_release() not handle the unregister of yank(), but leave that to callers? Then we keep the rule of only register yank for each ioc once. We can also have yet another wrapper migration_file_release_with_yank() to unregister the yank before calling migration_file_release(). -- Peter Xu
