On Fri, 4 Aug 2023 at 13:13, Peter Maydell <[email protected]> wrote: > > On Wed, 26 Jul 2023 at 14:56, Sergey Kambalin <[email protected]> wrote: > > > > Introducing Raspberry Pi 4B model. > > It contains new BCM2838 SoC, PCIE subsystem, > > RNG200, Thermal sensor and Genet network controller. > > > > It can work with recent linux kernels 6.x.x. > > Two avocado tests was added to check that. > > > > Unit tests has been made as read/write operations > > via mailbox properties. > > > > Genet integration test is under development. > > > > Every single commit > > 1) builds without errors > > 2) passes regression tests > > 3) passes style check* > > *the only exception is bcm2838-mbox-property-test.c file > > containing heavy macros usage which cause a lot of > > false-positives of checkpatch.pl. > > > > I did my best to keep the commits less than 200 changes, > > but had to make some of them a bit more in order to > > keep their integrity. > > Thanks for doing this -- I really like the way the split > has turned out, and the overall structure of the patchseries > is good. I'm going through the patches individually > (which will probably take me into next week to finish) > but I'm not seeing anything major, just some smaller > issues.
I got through the second half of the patchset faster than I expected, so I'm now done with my first pass review of it. Please let me know if you have any questions about my comments/suggestions on the individual patches. -- PMM
