On 8/2/23 06:08, Mikhail Tyutin wrote:
The fix is to clear TLB_INVALID_MASK bit in tlb_addr, as it happens in other places e.g. load_helper().

Signed-off-by: Dmitriy Solovev <[email protected]>
Signed-off-by: Mikhail Tyutin <[email protected]>
---
  accel/tcg/cputlb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

The other places in load_helper happen only directly after tlb_fill has succeeded. Here you have no such guarantee.

I think perhaps the save_iotlb_data() call should be applied to loads as well, and then tlb_plugin_lookup simplified.


r~

Reply via email to