On Mon, 26 Jun 2023 at 16:48, Richard Henderson
<[email protected]> wrote:
>
> From: Anton Johansson <[email protected]>
>
> Signed-off-by: Anton Johansson <[email protected]>
> Reviewed-by: Richard Henderson <[email protected]>
> Message-Id: <[email protected]>
> Signed-off-by: Richard Henderson <[email protected]>
> -static void log_cpu_exec(target_ulong pc, CPUState *cpu,
> +static void log_cpu_exec(vaddr pc, CPUState *cpu,
> const TranslationBlock *tb)
> {
> if (qemu_log_in_addr_range(pc)) {
> qemu_log_mask(CPU_LOG_EXEC,
> "Trace %d: %p [%08" PRIx64
> - "/" TARGET_FMT_lx "/%08x/%08x] %s\n",
> + "/%" VADDR_PRIx "/%08x/%08x] %s\n",
> cpu->cpu_index, tb->tc.ptr, tb->cs_base, pc,
> tb->flags, tb->cflags, lookup_symbol(pc));
This again has lost the zero-padding. I noticed this one because
I have a workflow where I post-process these log files to
extract the executed PC values.
We've also lost the "PC is padded to the appropriate size
depending on whether this is a 32-bit or 64-bit guest CPU",
which is a bit of a shame.
thanks
-- PMM
