03.07.2023 16:44, Alex Bennée wrote:
From: Nicholas Piggin <[email protected]>The final part of the reverse step and break handling is to bring the machine back to a debug stop state. gdb expects a response. A gdb 'rsi' command hangs forever because the gdbstub filters out the response (also observable with reverse_debugging.py avocado tests). Fix by setting allow_stop_reply for the gdb backward packets. Fixes: 758370052fb ("gdbstub: only send stop-reply packets when allowed to") Cc: [email protected]
Hi! Are you guys sure this needs to be in -stable? To me it looks a sort of "partial revert" of a previous commit: commit 758370052fb602f9f23c3b8ae26a6133373c78e6 Author: Matheus Tavares Bernardino <[email protected]> Date: Thu May 4 12:37:31 2023 -0300 Subject: gdbstub: only send stop-reply packets when allowed to which introduced `allow_stop_reply' field in GdbCmdParseEntry. This change ("gdbstub: Permit..") does not work in 8.0 without the above mentioned "gdbstub: only send" commit, and I guess it is *not* supposed to be in stable. Or is it? I'm not applying this one to stable for now. Thanks, /mjt
Cc: Matheus Tavares Bernardino <[email protected]> Cc: Alex Bennée <[email protected]> Cc: Taylor Simpson <[email protected]> Signed-off-by: Nicholas Piggin <[email protected]> Acked-by: Matheus Tavares Bernardino <[email protected]> Message-Id: <[email protected]> Signed-off-by: Alex Bennée <[email protected]> Message-Id: <[email protected]> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index be18568d0a..9496d7b175 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1814,6 +1814,7 @@ static int gdb_handle_packet(const char *line_buf) .handler = handle_backward, .cmd = "b", .cmd_startswith = 1, + .allow_stop_reply = true, .schema = "o0" }; cmd_parser = &backward_cmd_desc;
