On Mon, Jun 26, 2023 at 07:29:26PM +0530, Ani Sinha wrote: > > > > On 26-Jun-2023, at 7:26 PM, Ani Sinha <[email protected]> wrote: > > > > > > > >> On 26-Jun-2023, at 7:24 PM, Michael S. Tsirkin <[email protected]> wrote: > >> > >> Ani, two versions a day is too much, > > > > So you suggesting I slow down my CPU freq? :-) > > Btw, the libvirt guys does this better in this respect I think. The > maintainer takes the patchset but if small rework in commit logs or comments > etc is needed, the maintainer does this himself and pushes the patch. That > way there is less churn.
I can do that too sometimes. I'm less of a dictator, prefer to get acks from others :) > > > >> pls don't unless first one > >> has been sent by mistake or something. then explain what > >> it was pls. > > > > I did say > > > > v4: reword commit log for patch 4 Oh, missed that. it's ok then, just make this a bit more prominent: note: no changes to patches, just commit log tweaks. > >> > >> On Mon, Jun 26, 2023 at 07:23:19PM +0530, Ani Sinha wrote: > >>> Patches 1-4: > >>> Fix tests so that devices do not use non-zero slots on the pcie root > >>> ports. PCIE ports only have one slot, so PCIE devices can only be > >>> plugged into slot 0 on a PCIE port. > >>> > >>> Patch 5: > >>> Enforce only one slot on PCIE port. > >>> > >>> The test fixes must be applied before the QEMU change that checks for use > >>> of a single slot in PCIE port. > >>> > >>> CC: [email protected] > >>> CC: [email protected] > >>> CC: [email protected] > >>> CC: [email protected] > >>> CC: [email protected] > >>> CC: [email protected] > >>> > >>> Changelog: > >>> v4: reword commit log for patch 4. > >>> v3: tags added. reword the error description in patch 5. Reword commit > >>> log in patch 4. > >>> v2: add hd-geo-test fix as well as the actual QEMU code fix to the > >>> patchset. > >>> The patches are added in the right order. > >>> > >>> Ani Sinha (5): > >>> tests/acpi: allow changes in DSDT.noacpihp table blob > >>> tests/acpi/bios-tables-test: use the correct slot on the > >>> pcie-root-port > >>> tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp > >>> tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and > >>> simplify test > >>> hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port > >>> > >>> hw/pci/pci.c | 6 ++++++ > >>> tests/data/acpi/q35/DSDT.noacpihp | Bin 8248 -> 8241 bytes > >>> tests/qtest/bios-tables-test.c | 4 ++-- > >>> tests/qtest/hd-geo-test.c | 18 ++++++++---------- > >>> 4 files changed, 16 insertions(+), 12 deletions(-) > >>> > >>> -- > >>> 2.39.1 > >> > >
