On 23.06.23 07:58, Michael S. Tsirkin wrote:
On Tue, Jun 13, 2023 at 05:02:05PM +0200, David Hildenbrand wrote:
One limitation of virtio-mem is that we cannot currently unplug virtio-mem
devices that have all memory unplugged from the VM.
Let's properly handle forced unplug (as can be triggered by the VM) and
add support for ordinary unplug (requests) of virtio-mem devices that are
in a compatible state (no legacy mode, no plugged memory, no plug request).
Briefly tested on both, x86_64 and aarch64.
Cc: Peter Maydell <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Eduardo Habkost <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Marcel Apfelbaum <[email protected]>
Cc: Igor Mammedov <[email protected]>
Cc: [email protected]
Cc: Gavin Shan <[email protected]>
Lots of duplication pc/arm. Which is not new but do we have to keep
growing this? Can't we put at least the new common code somewhere?
There are some minor differences in the code, but I guess we could
factor the (un)plug handlers out.
hw/virtio/virtio-md.c
include/hw/virtio/virtio-md.c
?
--
Cheers,
David / dhildenb