Re: [PATCH qemu 2/2] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer

Tue, 20 Jun 2023 00:32:51 -0700 

On 6/8/23 11:06, ~foxes wrote:

From: Foxes Hung <[email protected]>

Signed-off-by: Foxes Hung <[email protected]>
---
  gdbstub/syscalls.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c
index 02e3a8f74c..4c6b5f728b 100644
--- a/gdbstub/syscalls.c
+++ b/gdbstub/syscalls.c
@@ -126,7 +126,7 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const char 
*fmt, ...)
              case 's':
                  i64 = va_arg(va, uint64_t);
                  i32 = va_arg(va, uint32_t);
-                p += snprintf(p, p_end - p, "%" PRIx64 "/%x" PRIx32, i64, i32);
+                p += snprintf(p, p_end - p, "%" PRIx64 "/%" PRIx32, i64, i32);
                  break;
              default:
              bad_format:


Reviewed-by: Richard Henderson <[email protected]>

r~

Reply via email to